MercAutoEquip #1141
Open
MercAutoEquip #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for account with more than 8 chars add flash for various move/town tasks to alleviate desync issues fix item color handling for non-standard string tables fix bug with runeword base check
GameAction, MuleLogger, Misc -Add missing var declaration from last commit
Set previous only when result is set. Now checks area id only when result is false for better performance.
Fix Storage.IsLocked error by checking for both parent type and gid
mercautoequip
Create MercAutoEquipExample.nip
Closed
noah-
requested changes
Jan 28, 2019
| return false; | ||
| } | ||
|
|
||
| if (typeof bodyLocMerc === "number") { |
There was a problem hiding this comment.
refactor idea, remove this "number" check and assign as array to begin with:
bodyLocMerc = [5]; etc
There was a problem hiding this comment.
This is need it as its need it for player auto equip. Im wrong?
There was a problem hiding this comment.
break;
default:
return false;
}
if (typeof bodyLoc === "number") {
bodyLoc = [bodyLoc];
}
return bodyLoc;
},
this one is for the player
d2bs/kolbot/libs/common/Misc.js
Outdated
| classid = items[0].classid; | ||
|
|
||
| if (this.equipMerc(items[0], bodyLoc[j])) { | ||
| Misc.logItem("Equipped Merc", me.getItem(-1, -1, gid)); |
There was a problem hiding this comment.
run the eslint or jslint to fix any formatting issues like this
|
|
||
| for (i = 0; i < 3; i += 1) { | ||
| if (item.toCursor()) { | ||
| var gid = item.gid; |
There was a problem hiding this comment.
don't think this is needed since you commented out logitem, consider removing this code and related comments
| } | ||
| } | ||
| } | ||
| return true; |
d2bs/kolbot/libs/common/Misc.js
Outdated
| bodyLocMerc = 3; | ||
|
|
||
| break; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noah- as you requested all in one patch